core icon indicating copy to clipboard operation
core copied to clipboard

`shards unassign` command no longer stalls

Open saterus opened this issue 2 years ago • 1 comments

This fixes a bug which caused the shard supervisor to stall indefinitely. If it ran shards unassign and there was nothing to be unassigned, it would never increment the etcd revision with its transaction. Then when we waited to observe our changes as reflected by the etcd mod revision, we would end up waiting until the next arbitrary transaction to complete. Needless to say, this is not the desired behavior.

Also adds a timeout to the command more generally.


This change is Reviewable

saterus avatar May 02 '22 17:05 saterus

@jgraettinger Is this good to go out?

saterus avatar Jun 22 '22 14:06 saterus