sdformat icon indicating copy to clipboard operation
sdformat copied to clipboard

Python: Added OpticalFrameID and SetOpticalFrameID to pyCamera

Open ahcorde opened this issue 2 years ago • 1 comments

Signed-off-by: ahcorde [email protected]

🎉 New feature

Closes https://github.com/gazebosim/sdformat/issues/1128

Summary

Python: Added OpticalFrameID and SetOpticalFrameID to pyCamera

Checklist

  • [x] Signed all commits for DCO
  • [x] Added tests
  • [ ] Added example and/or tutorial
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [x] Consider updating Python bindings (if the library has them)
  • [x] codecheck passed (See contributing)
  • [x] All tests passed (See test coverage)
  • [x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

ahcorde avatar Oct 10 '22 08:10 ahcorde

Codecov Report

Merging #1184 (6694cd4) into sdf13 (ffea2ed) will decrease coverage by 0.00%. The diff coverage is 50.00%.

:exclamation: Current head 6694cd4 differs from pull request most recent head d28488c. Consider uploading reports for the commit d28488c to get more accurate results

@@            Coverage Diff             @@
##            sdf13    #1184      +/-   ##
==========================================
- Coverage   87.06%   87.05%   -0.01%     
==========================================
  Files         125      125              
  Lines       15983    15987       +4     
==========================================
+ Hits        13915    13917       +2     
- Misses       2068     2070       +2     
Impacted Files Coverage Δ
python/src/sdf/pyCamera.cc 57.01% <50.00%> (-0.13%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 10 '22 08:10 codecov[bot]