sdformat icon indicating copy to clipboard operation
sdformat copied to clipboard

ForceTorque: update calls to use sdf::Errors parameters

Open marcoag opened this issue 2 years ago • 1 comments

Signed-off-by: Marco A. Gutierrez [email protected]

🎉 New feature

Work towards https://github.com/gazebosim/sdformat/issues/820.

Depends on https://github.com/gazebosim/sdformat/pull/1151 and: https://github.com/gazebosim/sdformat/pull/1141.

Summary

Adds missing Errors structure parameters in a few methods of the ForceTorque class.

Test it

Using the ForceTorque class should report all errors through sdf::Errors if the errors parameter is used, it should print them otherwise.

Checklist

  • [x] Signed all commits for DCO
  • [ ] Added tests
  • [ ] Added example and/or tutorial
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [x] codecheck passed (See contributing)
  • [x] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

marcoag avatar Sep 20 '22 07:09 marcoag

Codecov Report

Merging #1163 (51bd39a) into sdf13 (4219b99) will decrease coverage by 0.10%. The diff coverage is 100.00%.

:exclamation: Current head 51bd39a differs from pull request most recent head 7fe76a9. Consider uploading reports for the commit 7fe76a9 to get more accurate results

@@            Coverage Diff             @@
##            sdf13    #1163      +/-   ##
==========================================
- Coverage   87.54%   87.45%   -0.10%     
==========================================
  Files         126      126              
  Lines       16462    16356     -106     
==========================================
- Hits        14412    14304     -108     
- Misses       2050     2052       +2     
Impacted Files Coverage Δ
src/ForceTorque.cc 90.44% <100.00%> (+0.44%) :arrow_up:

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 03 '22 18:10 codecov[bot]