sdformat
sdformat copied to clipboard
Altimeter: update calls to use sdf::Errors parameters
Signed-off-by: Marco A. Gutierrez [email protected]
🎉 New feature
Work towards https://github.com/gazebosim/sdformat/issues/820.
Depends on https://github.com/gazebosim/sdformat/pull/1151 and: https://github.com/gazebosim/sdformat/pull/1141.
Summary
Adds missing Errors
structure parameters in a few methods of the Altimeter
class.
Test it
Using the Altimeter
class should report all errors through sdf::Errors
if the errors
parameter is used, it should print them otherwise.
Checklist
- [x] Signed all commits for DCO
- [ ] Added tests
- [ ] Added example and/or tutorial
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [x]
codecheck
passed (See contributing) - [x] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by
messages.
Codecov Report
Merging #1160 (ec82caf) into sdf13 (1d1f1d5) will increase coverage by
0.01%
. The diff coverage is97.08%
.
:exclamation: Current head ec82caf differs from pull request most recent head 4984ddb. Consider uploading reports for the commit 4984ddb to get more accurate results
@@ Coverage Diff @@
## sdf13 #1160 +/- ##
==========================================
+ Coverage 87.51% 87.53% +0.01%
==========================================
Files 126 126
Lines 16248 16446 +198
==========================================
+ Hits 14220 14396 +176
- Misses 2028 2050 +22
Impacted Files | Coverage Δ | |
---|---|---|
include/sdf/Plugin.hh | 93.75% <ø> (ø) |
|
src/Element.cc | 96.21% <88.23%> (-1.01%) |
:arrow_down: |
include/sdf/Element.hh | 97.67% <95.23%> (-2.33%) |
:arrow_down: |
src/Material.cc | 95.76% <95.34%> (+0.39%) |
:arrow_up: |
src/ParticleEmitter.cc | 92.55% <97.77%> (+0.32%) |
:arrow_up: |
python/src/sdf/pyError.cc | 80.82% <100.00%> (+0.54%) |
:arrow_up: |
src/AirPressure.cc | 100.00% <100.00%> (ø) |
|
src/Altimeter.cc | 100.00% <100.00%> (ø) |
|
src/Frame.cc | 96.55% <100.00%> (+0.21%) |
:arrow_up: |
src/Imu.cc | 100.00% <100.00%> (ø) |
|
... and 5 more |
... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.