sdformat
sdformat copied to clipboard
Physics: update calls to use sdf::Errors parameters
Signed-off-by: Marco A. Gutierrez [email protected]
🎉 New feature
Work towards https://github.com/gazebosim/sdformat/issues/820.
Depends on: https://github.com/gazebosim/sdformat/pull/1141.
Summary
Adds missing Errors
structure parameters in a few methods of the Physics
class.
Test it
Using the Physics
class should report all errors through sdf::Errors
if the errors
parameter is used, it should print them otherwise.
Checklist
- [x] Signed all commits for DCO
- [ ] Added tests
- [ ] Added example and/or tutorial
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [x]
codecheck
passed (See contributing) - [x] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by
messages.
Codecov Report
Merging #1157 (868fcb5) into sdf13 (1d1f1d5) will decrease coverage by
0.07%
. The diff coverage is94.27%
.
:exclamation: Current head 868fcb5 differs from pull request most recent head a90c80b. Consider uploading reports for the commit a90c80b to get more accurate results
@@ Coverage Diff @@
## sdf13 #1157 +/- ##
==========================================
- Coverage 87.51% 87.45% -0.07%
==========================================
Files 126 126
Lines 16248 16358 +110
==========================================
+ Hits 14220 14306 +86
- Misses 2028 2052 +24
Impacted Files | Coverage Δ | |
---|---|---|
include/sdf/Plugin.hh | 93.75% <ø> (ø) |
|
src/Element.cc | 96.21% <88.23%> (-1.01%) |
:arrow_down: |
include/sdf/Element.hh | 97.67% <95.23%> (-2.33%) |
:arrow_down: |
python/src/sdf/pyError.cc | 80.82% <100.00%> (+0.54%) |
:arrow_up: |
src/Noise.cc | 96.09% <100.00%> (+0.26%) |
:arrow_up: |
src/Physics.cc | 87.05% <100.00%> (+1.53%) |
:arrow_up: |
src/Plugin.cc | 100.00% <100.00%> (ø) |
... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.