sdformat
sdformat copied to clipboard
Light: update calls to use sdf::Errors parameters
Signed-off-by: Marco A. Gutierrez [email protected]
🎉 New feature
Work towards https://github.com/gazebosim/sdformat/issues/820.
Depends on: https://github.com/gazebosim/sdformat/pull/1141.
Summary
Adds missing Errors
structure parameters in a few methods of the Light
class.
Test it
Using the Light
class should report all errors through sdf::Errors
if the errors
parameter is used, it should print them otherwise.
Checklist
- [x] Signed all commits for DCO
- [ ] Added tests
- [ ] Added example and/or tutorial
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [x]
codecheck
passed (See contributing) - [x] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by
messages.
Codecov Report
Merging #1154 (f33e935) into sdf13 (a5be6ab) will decrease coverage by
0.12%
. The diff coverage is87.28%
.
@@ Coverage Diff @@
## sdf13 #1154 +/- ##
==========================================
- Coverage 87.05% 86.92% -0.13%
==========================================
Files 125 125
Lines 15961 16049 +88
==========================================
+ Hits 13895 13951 +56
- Misses 2066 2098 +32
Impacted Files | Coverage Δ | |
---|---|---|
src/Element.cc | 92.53% <78.12%> (-3.29%) |
:arrow_down: |
include/sdf/Element.hh | 97.72% <95.23%> (-2.28%) |
:arrow_down: |
src/Light.cc | 93.13% <100.00%> (+0.34%) |
:arrow_up: |
src/Param.cc | 86.93% <0.00%> (-0.85%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.