sdformat
sdformat copied to clipboard
Param: update calls to use sdf::Errors parameters
Signed-off-by: Marco A. Gutierrez [email protected]
🎉 New feature
Work towards https://github.com/gazebosim/sdformat/issues/820.
Summary
Adds missing Errors
structure parameters in a few calls on the Param class.
Test it
Using the Param class should report all errors through sdf::Errors
.
Checklist
- [x] Signed all commits for DCO
- [ ] Added tests
- [ ] Added example and/or tutorial
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [x]
codecheck
passed (See contributing) - [x] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by
messages.
Codecov Report
Merging #1140 (72d22fd) into sdf13 (a5be6ab) will decrease coverage by
0.34%
. The diff coverage is83.20%
.
:exclamation: Current head 72d22fd differs from pull request most recent head e2c90ff. Consider uploading reports for the commit e2c90ff to get more accurate results
@@ Coverage Diff @@
## sdf13 #1140 +/- ##
==========================================
- Coverage 87.05% 86.71% -0.35%
==========================================
Files 125 125
Lines 15961 15964 +3
==========================================
- Hits 13895 13843 -52
- Misses 2066 2121 +55
Impacted Files | Coverage Δ | |
---|---|---|
include/sdf/Element.hh | 100.00% <ø> (ø) |
|
include/sdf/Param.hh | 80.72% <ø> (ø) |
|
src/Utils.hh | 94.73% <ø> (ø) |
|
src/Element.cc | 95.81% <78.49%> (ø) |
|
src/Utils.cc | 86.54% <83.33%> (ø) |
|
src/Param.cc | 87.78% <100.00%> (ø) |
|
src/PrintConfig.cc | 100.00% <100.00%> (ø) |
|
src/World.cc | 95.52% <100.00%> (ø) |
|
src/parser_urdf.cc | 84.97% <0.00%> (-2.78%) |
:arrow_down: |
src/Camera.cc | 87.78% <0.00%> (-1.25%) |
:arrow_down: |
... and 9 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.