sdformat icon indicating copy to clipboard operation
sdformat copied to clipboard

Sensor: add sdf::Errors output to API methods

Open marcoag opened this issue 2 years ago • 1 comments

Signed-off-by: Marco A. Gutierrez [email protected]

🎉 New feature

Work towards https://github.com/gazebosim/sdformat/issues/820.

Summary

Makes errors to be reported through sdf::Errors when using the ToElement(sdf::Errors &_errors) method of the Sensor class.

Test it

Using the ToElement(sdf::Errors &_errors) method of the Sensor class should report all errors through sdf::Errors.

Checklist

  • [x] Signed all commits for DCO
  • [x] Added tests
  • [ ] Added example and/or tutorial
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [x] codecheck passed (See contributing)
  • [x] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

marcoag avatar Sep 12 '22 08:09 marcoag

Codecov Report

Merging #1138 (135da9e) into sdf13 (74b5785) will decrease coverage by 0.00%. The diff coverage is 91.66%.

@@            Coverage Diff             @@
##            sdf13    #1138      +/-   ##
==========================================
- Coverage   87.20%   87.20%   -0.01%     
==========================================
  Files         124      124              
  Lines       16222    16229       +7     
==========================================
+ Hits        14146    14152       +6     
- Misses       2076     2077       +1     
Impacted Files Coverage Δ
src/Sensor.cc 92.92% <91.66%> (-0.16%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 14 '22 14:09 codecov[bot]