sdformat icon indicating copy to clipboard operation
sdformat copied to clipboard

Move stream operator implementations to Plugin.cc

Open scpeters opened this issue 2 years ago • 1 comments

🦟 Bug fix

Split out from #1021.

Summary

This moves stream operator implementations from Plugin.hh to Plugin.cc. It was included in #1021, but there are strange ABI complaints, so I'm targeting it as a separate pull request.

Checklist

  • [X] Signed all commits for DCO
  • [ ] Added tests
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [X] codecheck passed (See contributing)
  • [X] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

scpeters avatar Aug 12 '22 00:08 scpeters

Codecov Report

Merging #1111 (a0ae5b5) into sdf12 (a84742c) will not change coverage. The diff coverage is 93.33%.

:exclamation: Current head a0ae5b5 differs from pull request most recent head bfa8434. Consider uploading reports for the commit bfa8434 to get more accurate results

@@           Coverage Diff           @@
##            sdf12    #1111   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          80       80           
  Lines       13086    13086           
=======================================
  Hits        11946    11946           
  Misses       1140     1140           
Impacted Files Coverage Δ
include/sdf/Plugin.hh 100.00% <ø> (+6.25%) :arrow_up:
src/Plugin.cc 99.15% <93.33%> (-0.85%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 12 '22 00:08 codecov[bot]

Closing since #1021 is no longer needed and we still don't know why the ABI is broken.

azeey avatar Oct 11 '22 23:10 azeey

Closing since #1021 is no longer needed and we still don't know why the ABI is broken.

also the windows build was broken

scpeters avatar Oct 12 '22 00:10 scpeters