sdformat
sdformat copied to clipboard
Adding sdf::Errors as an error output option to PrintConfig methods
Signed-off-by: Marco A. Gutierrez [email protected]
🎉 New feature
Work towards #820
Summary
Adds sdf::Errors
for as an error report option to all the methods on the PrintConfig class.
Test it
Calling the new functions that contain the sdf::Errors
parameter should only add errors to the sdf::Errors
data structure and not produce any printed output or throw any exceptions.
Checklist
- [x] Signed all commits for DCO
- [x] Added tests
- [ ] Added example and/or tutorial
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [x]
codecheck
passed (See contributing) - [x] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by
messages.
Codecov Report
Merging #1098 (c62ae88) into main (bbb9c8f) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1098 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 125 125
Lines 15958 15965 +7
=======================================
+ Hits 13836 13843 +7
Misses 2122 2122
Impacted Files | Coverage Δ | |
---|---|---|
src/PrintConfig.cc | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Removed the Garden
label because we're past feature freeze ❄️ .
This PR can either be merged into main
and backported to sdf13
after the stable release, or retargeted to sdf13
and merged after the stable release (i.e. October).
Due to code dependencies I will wait on https://github.com/gazebosim/sdformat/pull/1095 before updating this PR.
Since https://github.com/gazebosim/sdformat/pull/1095 is in I went ahead and addressed the comments above.