gz-transport icon indicating copy to clipboard operation
gz-transport copied to clipboard

ABI broken between 7.1.0 and 7.2.0

Open osrf-migration opened this issue 4 years ago • 4 comments

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


A parameter with a default value was added to ignition::transport::log::Playback::Start in pull request #401. It was merged and released in 7.2.0, but we didn't notice the complaints by the ABI checking job:

  • Build Status https://build.osrfoundation.org/job/ignition_transport-abichecker-any_to_any-ubuntu_auto-amd64/103/API_5fABI_20report/

  • https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-transport/pull-requests/401/subt-enable-fast-log-playback/diff#comment-129364518

cc @j-rivero

osrf-migration avatar Dec 18 '19 20:12 osrf-migration