Update added-mass of lrauv model and remove added mass definitions from examples
π¦ Bug fix
Fixes #2575
Summary
Since, we have decided to deprecate added mass in the hydrodynamics plugin in favor of using the SDFormat fluid_added_mass tag (See #2493 ), we should update our examples to avoid the warning.
TODO: Update maritime tutorials and migration guide.
Checklist
- [ ] Signed all commits for DCO
- [ ] Added tests
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [ ]
codecheckpassed (See contributing) - [ ] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.
πΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈ
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.76%. Comparing base (
1d6651d) to head (dfee475). Report is 42 commits behind head on gz-sim9.
Additional details and impacted files
@@ Coverage Diff @@
## gz-sim9 #2608 +/- ##
===========================================
+ Coverage 68.73% 68.76% +0.02%
===========================================
Files 341 341
Lines 33011 33049 +38
===========================================
+ Hits 22690 22726 +36
- Misses 10321 10323 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@srmainwaring would you be available for a quick review?