gz-sim icon indicating copy to clipboard operation
gz-sim copied to clipboard

[Work in progress] Fix gz-sim on Windows

Open traversaro opened this issue 1 year ago • 1 comments

🦟 Bug fix

Fixes #<NUMBER>

Summary

This work in progress PR permits to run gz sim on Windows. It is currently in draft, but I opened it to avoid the risk of losing the changes.

Checklist

  • [ ] Signed all commits for DCO
  • [ ] Added tests
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [ ] codecheck passed (See contributing)
  • [ ] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

traversaro avatar Apr 30 '24 16:04 traversaro

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.89%. Comparing base (ab18888) to head (4bf5328). Report is 91 commits behind head on gz-sim8.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2392      +/-   ##
===========================================
+ Coverage    65.75%   65.89%   +0.14%     
===========================================
  Files          327      327              
  Lines        31233    31314      +81     
===========================================
+ Hits         20537    20635      +98     
+ Misses       10696    10679      -17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 30 '24 20:04 codecov[bot]

@traversaro are you planning to get this in for the Ionic release? If not, no worries, just let me know and I'll remove the beta label.

azeey avatar Aug 06 '24 23:08 azeey

@traversaro, as far as I know the preferred direction here is to implement the standalone binaries, but we don't have a PR for that for gz-sim yet, so I'll go ahead and remove the beta label. My hope is to get back to https://github.com/gazebosim/gz-tools/issues/7 once Ionic is released.

azeey avatar Aug 12 '24 19:08 azeey

@traversaro, as far as I know the preferred direction here is to implement the standalone binaries, but we don't have a PR for that for gz-sim yet, so I'll go ahead and remove the beta label.

Sorry, my bad, I forgot to reply. I totally agree, handling all the signal passing with Ruby proved to be impossible, see https://github.com/gazebosim/gz-sim/issues/2393#issuecomment-2089810431 for more details. I think we can safely close this PR.

traversaro avatar Aug 12 '24 19:08 traversaro