gz-sim icon indicating copy to clipboard operation
gz-sim copied to clipboard

Tidy SdfEntityCreator

Open mjcarroll opened this issue 2 years ago • 2 comments

Switch SdfEntityCreator to use ImplPtr.

Remove duplicated EntityCreator functionality from LevelManager

mjcarroll avatar Sep 28 '23 17:09 mjcarroll

homebrew is not happy? there're quite a few test failures.

iche033 avatar Oct 05 '23 22:10 iche033

homebrew is not happy? there're quite a few test failures.

I'm assuming this is also because it's targeting main? I will change this to draft until I can confirm that CI is happy for main.

mjcarroll avatar Oct 05 '23 22:10 mjcarroll

@mjcarroll Now that https://github.com/gazebosim/gz-sim/pull/2452 is in and on it's way to main (#2504), should we close this PR?

azeey avatar Aug 12 '24 19:08 azeey