gz-sim icon indicating copy to clipboard operation
gz-sim copied to clipboard

Remove actors from screen when they are supposed to

Open arjo129 opened this issue 3 years ago • 2 comments

🦟 Bug fix

Fixes #<NUMBER>

Summary

Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils.

Before

bug

After

no_bug

Notes:

Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all. Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes?

Checklist

  • [ ] Signed all commits for DCO
  • [ ] Added tests
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [ ] codecheck passed (See contributing)
  • [ ] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

arjo129 avatar Sep 12 '22 01:09 arjo129

Codecov Report

:exclamation: No coverage uploaded for pull request base (gz-sim7@2f10426). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             gz-sim7    #1697   +/-   ##
==========================================
  Coverage           ?   63.88%           
==========================================
  Files              ?      334           
  Lines              ?    26346           
  Branches           ?        0           
==========================================
  Hits               ?    16831           
  Misses             ?     9515           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 12 '22 02:09 codecov[bot]

should I backport these changes?

Can you go ahead and target this to the earlier version and we can get it on a forward port?

mjcarroll avatar Sep 12 '22 13:09 mjcarroll