gz-sim icon indicating copy to clipboard operation
gz-sim copied to clipboard

Enable/Disable individual hydrodynamic components.

Open arjo129 opened this issue 3 years ago • 1 comments

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #<NUMBER>

Summary

This commit enables and disables individual components of the hydrodynamics. This is often useful for debugging odd behaviours of a hydrodynamic model.

Signed-off-by: Arjo Chakravarty [email protected]

Test it

Checklist

  • [ ] Signed all commits for DCO
  • [ ] Added tests
  • [ ] Added example and/or tutorial
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [ ] codecheck passed (See contributing)
  • [ ] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by message

arjo129 avatar Sep 07 '22 01:09 arjo129

Codecov Report

Merging #1692 (12726e3) into ign-gazebo6 (96b282b) will decrease coverage by 0.07%. The diff coverage is 53.12%.

@@               Coverage Diff               @@
##           ign-gazebo6    #1692      +/-   ##
===============================================
- Coverage        64.73%   64.65%   -0.08%     
===============================================
  Files              321      321              
  Lines            26130    26275     +145     
===============================================
+ Hits             16915    16988      +73     
- Misses            9215     9287      +72     
Impacted Files Coverage Δ
include/ignition/gazebo/SystemLoader.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.hh 28.57% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.cc 5.31% <2.77%> (-0.31%) :arrow_down:
src/systems/thruster/Thruster.cc 89.50% <85.18%> (-0.87%) :arrow_down:
src/SystemLoader.cc 67.46% <94.11%> (+3.95%) :arrow_up:
src/Conversions.cc 84.18% <100.00%> (+0.12%) :arrow_up:
src/ServerPrivate.cc 82.96% <100.00%> (ø)
src/SystemManager.cc 97.63% <100.00%> (+0.55%) :arrow_up:
src/systems/hydrodynamics/Hydrodynamics.cc 88.53% <100.00%> (+0.45%) :arrow_up:
src/Util.cc 93.44% <0.00%> (+0.32%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 07 '22 03:09 codecov[bot]