gz-sim icon indicating copy to clipboard operation
gz-sim copied to clipboard

Implement environmental lookup sensors.

Open arjo129 opened this issue 2 years ago β€’ 1 comments

πŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”Έ

πŸŽ‰ New feature

Supercedes #1660.

Summary

Implements a lookup sensor for environmental data.

Test it

You can run the example world:

gz sim environmental_sensor.sdf

Then listen on the main topic:

gz topic -e -t /world/environmental_sensor_test/model/model_with_sensor/link/link/sensor/custom_sensor/environmental_sensor/humidity

Press play, you should see the sensor go from 80%-90% humidity within a second and then stopping.

Checklist

  • [x] Signed all commits for DCO
  • [x] Added tests
  • [ ] Added example and/or tutorial
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [ ] codecheck passed (See contributing)
  • [x] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

arjo129 avatar Sep 05 '22 08:09 arjo129

Codecov Report

:exclamation: No coverage uploaded for pull request base (mbari/gz-sim7@60f04df). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 0942c2e differs from pull request most recent head 0d67038. Consider uploading reports for the commit 0d67038 to get more accurate results

@@               Coverage Diff                @@
##             mbari/gz-sim7    #1691   +/-   ##
================================================
  Coverage                 ?   63.90%           
================================================
  Files                    ?      334           
  Lines                    ?    26344           
  Branches                 ?        0           
================================================
  Hits                     ?    16836           
  Misses                   ?     9508           
  Partials                 ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 13 '22 17:09 codecov[bot]

Most review comments still apply here @arjo129.

hidmic avatar Oct 19 '22 20:10 hidmic

OK looks like I dont know how to use git :man_facepalming: - I accidentally pushed all the fixes to #1748. Working on backporting :skull_and_crossbones:

arjo129 avatar Oct 26 '22 01:10 arjo129

On second thoughts it'll be faster to review #1748 straight away.

arjo129 avatar Oct 26 '22 01:10 arjo129