gz-sim icon indicating copy to clipboard operation
gz-sim copied to clipboard

Fix overflow if dropStr is large

Open onurtore opened this issue 1 year ago • 3 comments

🦟 Bug fix

Fixes https://github.com/gazebosim/gz-common/pull/393

Summary

Large mesh file names creates ugly error message due to overflow. This commit fixes this.

Checklist

  • [X] Signed all commits for DCO
  • [ ] Added tests
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [ ] codecheck passed (See contributing)
  • [ ] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

onurtore avatar Aug 17 '22 16:08 onurtore

You may want to target this at the gz-sim7 branch, so that the fix goes into the initial Garden release

chapulina avatar Aug 17 '22 17:08 chapulina

You may want to target this at the gz-sim7 branch, so that the fix goes into the initial Garden release

Do I have to create new PR for that?

onurtore avatar Aug 17 '22 17:08 onurtore

You may want to target this at the gz-sim7 branch, so that the fix goes into the initial Garden release

Do I have to create new PR for that?

I already did it, you should:

git rebase -i HEAD~2
# remove line *Bump main to 8.0.0~pre1 *
# save and exit
git push -f origin otore19/addNewLine2

ahcorde avatar Aug 17 '22 17:08 ahcorde

Homebrew failures don't seem to be related to this PR. Merging.

azeey avatar Mar 07 '23 23:03 azeey