Fix Windows and Doxygen

[chapulina]

🦟 Bug fix

• Closes https://github.com/gazebosim/gz-sim/issues/1409

Summary

Windows

The Windows build has been broken since

• #1536

This fixes in adding IGNITION_GAZEBO_GUI_VISIBLE. The GZ_SIM equivalent has already been added to gz-sim7 in #1633.

Doxygen

After a lot of digging, it turned out that the Doxygen crashes described in #1409 were caused by the inline namespace. The Doxygen version on Jammy (1.9.1) can't handle those well.

Warnings

Also fixed some compiler warnings that I saw on Jammy.

Checklist

• [x] Signed all commits for DCO
• [ ] Added tests
• [ ] Updated documentation (as needed)
• [ ] Updated migration guide (as needed)
• [ ] Consider updating Python bindings (if the library has them)
• [x] codecheck passed (See contributing)
• [x] All tests passed (See test coverage)
• [x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[codecov[bot]]

Codecov Report

Merging #1643 (55b554d) into ign-gazebo6 (8c9489d) will increase coverage by 0.02%. The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           ign-gazebo6    #1643      +/-   ##
===============================================
+ Coverage        64.40%   64.43%   +0.02%     
===============================================
  Files              320      320              
  Lines            25892    25892              
===============================================
+ Hits             16677    16683       +6     
+ Misses            9215     9209       -6     

Impacted Files	Coverage Δ
src/LevelManager.cc	89.19% <ø> (ø)
src/systems/elevator/Elevator.hh	100.00% <ø> (ø)
src/systems/elevator/ElevatorCommonPrivate.hh	0.00% <ø> (ø)
src/systems/elevator/ElevatorStateMachine.hh	0.00% <ø> (ø)
src/systems/elevator/state_machine/ActionsImpl.hh	92.30% <ø> (ø)
...elevator/state_machine/ElevatorStateMachineImpl.hh	73.52% <ø> (ø)
src/systems/elevator/state_machine/EventsImpl.hh	100.00% <ø> (ø)
src/systems/elevator/state_machine/GuardsImpl.hh	100.00% <ø> (ø)
src/systems/elevator/state_machine/StatesImpl.hh	94.73% <ø> (ø)
src/systems/elevator/utils/DoorTimer.hh	0.00% <ø> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Blast545]

jammy builds are failing on UNIT_Gui_TEST and I haven't seen this one before, could it be related to the changes made on: src/gui/QuickStartHandler.hh?

[Blast545]

@ros-pull-request-builder retest this please

[Blast545]

I wanted to take a closer look to the errors on Jammy and UNIT_Gui_TEST before approving, I'll track this internally with @Crola1702

[chapulina]

I wanted to take a closer look to the errors on Jammy and UNIT_Gui_TEST before approving, I'll track this internally with @Crola1702

Thanks! I believe those are pre-existing. It's good to get this PR in quickly so Windows CI runs and it doesn't get more broken.