gz-sim
gz-sim copied to clipboard
Replace pose for TransformControl with GzPose
Signed-off-by: youhy [email protected]
New feature
Summary
As title. The behavior should be exactly the same as before.
Test it
Checklist
- [x] Signed all commits for DCO
- [ ] Added tests
- [ ] Added example and/or tutorial
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [ ]
codecheck
passed (See contributing) - [ ] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by
messages.
Codecov Report
Merging #1642 (d71e224) into ign-gazebo3 (2a12514) will not change coverage. The diff coverage is
n/a
.
:exclamation: Current head d71e224 differs from pull request most recent head 54112d8. Consider uploading reports for the commit 54112d8 to get more accurate results
@@ Coverage Diff @@
## ign-gazebo3 #1642 +/- ##
============================================
Coverage 78.03% 78.03%
============================================
Files 255 255
Lines 15082 15082
============================================
Hits 11769 11769
Misses 3313 3313
@jennuine The width and height both worked for me but didn't work for you. So there is no way I know what size would work for you and the only thing I can do is to increase the height and width a bit.
About the precision, I doubt if we can have 2 decimals without editing GzPose again. So let's just keep it 4 decimals for now.
This is looking good @AzulRadio but requires a gz-gui3
release before it can be merged. It would be nice to get https://github.com/gazebosim/gz-gui/pull/466 in before then so I'll take over this PR next week. Thanks for all your hard work! :rocket:
Moving this to TODO to focus on the Garden release.
GzPose
will need some additional updates so we don't have recession of functionality (eg., spinbox min/max values for each element)