gz-sim icon indicating copy to clipboard operation
gz-sim copied to clipboard

Utilizes return value of AddBvhAnimation func

Open onurtore opened this issue 2 years ago • 1 comments

🦟 Bug fix

Related to https://github.com/gazebosim/gz-common/pull/393

Summary

During actor creation adding bvh animation might fail. The current approach does not check whether bvh animation fails or not. This patch, checks whether adding bvh animation is succesfull and logs if fails.

Checklist

  • [X] Signed all commits for DCO
  • [ ] Added tests
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [ ] codecheck passed (See contributing)
  • [ ] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

onurtore avatar Aug 07 '22 11:08 onurtore

Codecov Report

:exclamation: No coverage uploaded for pull request base (gz-sim7@c647de6). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             gz-sim7    #1632   +/-   ##
==========================================
  Coverage           ?   63.55%           
==========================================
  Files              ?      331           
  Lines              ?    25995           
  Branches           ?        0           
==========================================
  Hits               ?    16521           
  Misses             ?     9474           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 07 '22 12:08 codecov[bot]

Thanks for the PR. I've updated this and targeted to version 6 in #1750.

nkoenig avatar Oct 06 '22 17:10 nkoenig