gz-sim icon indicating copy to clipboard operation
gz-sim copied to clipboard

Update headers for missing transitive includes

Open mjcarroll opened this issue 2 years ago • 1 comments

🦟 Bug fix

Needed by https://github.com/gazebosim/gz-transport/pull/315

Summary

It turns out that gz-transport has been including gz/msgs.hh from a public header, so many downstream packages may be implicitly using the msgs header files without explicitly including them. That is certainly the case for gz-sim. As such, merging https://github.com/gazebosim/gz-transport/pull/315 would break any downstream packages without explicit include statements.

This pull request uses a neat trick enabled by https://github.com/gazebo-tooling/release-tools/pull/583 that allows the homebrew and windows jobs to build against the branch from https://github.com/gazebosim/gz-transport/pull/315 by using the ci_matching_branch/ prefix and updating the metadata in https://github.com/osrf/homebrew-simulation/commit/e08e0472bc15c129eb04a76e5b3a26afddfd199c and https://github.com/gazebo-tooling/gazebodistro/commit/7cbdc431d487a8a8e77e98fee6307abec67d4676 accordingly.

Checklist

  • [ ] Signed all commits for DCO
  • [ ] Added tests
  • [ ] Updated documentation (as needed)
  • [ ] Updated migration guide (as needed)
  • [ ] Consider updating Python bindings (if the library has them)
  • [ ] codecheck passed (See contributing)
  • [ ] All tests passed (See test coverage)
  • [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

mjcarroll avatar Jun 30 '22 17:06 mjcarroll

I think we need fixes to gz-gui before this will build cleanly

scpeters avatar Jun 30 '22 19:06 scpeters

Codecov Report

:exclamation: No coverage uploaded for pull request base (gz-sim7@6184b54). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             gz-sim7    #1566   +/-   ##
==========================================
  Coverage           ?   63.90%           
==========================================
  Files              ?      334           
  Lines              ?    26344           
  Branches           ?        0           
==========================================
  Hits               ?    16836           
  Misses             ?     9508           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 31 '22 00:08 codecov[bot]