gz-sim
gz-sim copied to clipboard
Common widget GzColor replacement
New feature
- Part of #310
Summary
Replace implementation for lights (Lights.qml
) and material color (Material.qml
) in Component Inspector with GzColor introduced in gz-gui#411
For future maintainers: selecting color with the Material panel has a bug where the color of the material doesn't change when a color is selected. This bug is not introduced by this common widget.
Test it
Draft because of a possible bug in the Gazebo which causes the colors of the lights and material color can only be changed once.
Checklist
- [ ] Signed all commits for DCO
- [ ] Added tests
- [ ] Added example and/or tutorial
- [ ] Updated documentation (as needed)
- [ ] Updated migration guide (as needed)
- [ ] Consider updating Python bindings (if the library has them)
- [ ]
codecheck
passed (See contributing) - [ ] All tests passed (See test coverage)
- [ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by
messages.
Codecov Report
Merging #1530 (7b52abf) into ign-gazebo6 (8c9489d) will increase coverage by
0.09%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## ign-gazebo6 #1530 +/- ##
===============================================
+ Coverage 64.40% 64.50% +0.09%
===============================================
Files 320 320
Lines 25892 25861 -31
===============================================
+ Hits 16677 16682 +5
+ Misses 9215 9179 -36
Impacted Files | Coverage Δ | |
---|---|---|
.../plugins/component_inspector/ComponentInspector.cc | 5.61% <0.00%> (+0.28%) |
:arrow_up: |
src/Util.cc | 93.11% <0.00%> (-0.33%) |
:arrow_down: |
src/SimulationRunner.cc | 91.89% <0.00%> (+0.95%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This PR needs a release from gz-gui6
but I'm waiting until the plotting PR is ready and merged (ref: https://github.com/gazebosim/gz-sim/pull/1571#issuecomment-1190430491)