Pending TODOs Ignition Garden

[ahcorde]

List of TODOs to review before Garden release

• [ ] /// \todo(anyone) Move to GuiRunner::Implementation when porting to v5
  • https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo7/src/gui/GuiRunner.hh#L74
• [x] // \todo(anyone) Change this to uint64_t in Ignition H?
  • https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo6/src/systems/shader_param/ShaderParam.cc#L288
  • https://github.com/ignitionrobotics/ign-gazebo/pull/1451
• [ ] / \todo(anyone) instead of using ifdef to check for macOS, expose add an accessor function to get the GraphicsApi from rendering::RenderEngine
  • https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo6/src/systems/shader_param/ShaderParam.cc#L317-L320
• [ ] // \todo handle args for constants in ign-rendering
  • https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo6/src/systems/shader_param/ShaderParam.cc#L365

[chapulina]

We can also update our context menu:

https://github.com/ignitionrobotics/ign-gazebo/blob/fc9cadd680e1414b38be71b404958aa8e16ff70d/src/gui/plugins/modules/EntityContextMenu.qml#L52-L73

[ahcorde]

• [x] Use the field is_light_off in light.proto from Garden on.
  • https://github.com/ignitionrobotics/ign-gazebo/pull/1449
• [x] Use the field visualize_visual in light.proto from Garden on.
  • https://github.com/ignitionrobotics/ign-msgs/pull/248
  • https://github.com/ignitionrobotics/ign-gazebo/pull/1453

[jennuine]

/// \todo(anyone) Move to GuiRunner::Implementation when porting to v5 https://github.com/gazebosim/gz-sim/blob/c52e1405713c04e72859c4e8031ed153348d233f/src/gui/GuiRunner.hh#L78

The todo comment will be removed in https://github.com/gazebosim/gz-sim/pull/1678

[azeey]

Looks like the first item is done as @jennuine mentioned. I don't think we have time to handle the rest before the Garden release.

[iche033]

the 3rd todo should be addressed by https://github.com/gazebosim/gz-sim/pull/1713

[azeey]

I think only the last item is left. @iche033 Can we close this issue and create a separate issue for item 4?

[iche033]

I think only the last item is left. @iche033 Can we close this issue and create a separate issue for item 4?

yes that sounds good to me