gz-rendering icon indicating copy to clipboard operation
gz-rendering copied to clipboard

Dummy ignition::rendering::BaseCamera::SaveFrame

Open agayev169 opened this issue 5 years ago • 3 comments

ignition::rendering::BaseCamera::SaveFrame is a dummy function. Please, either mention this in the documentation or write the function.

agayev169 avatar Jun 02 '20 20:06 agayev169

All functions on BaseCamera are virtual functions that can be reimplemented by each rendering engine.

So I imagine what you're asking for is for that function to be implemented on either Ogre or Ogre2, right?

chapulina avatar Jun 08 '20 20:06 chapulina

I use Ogre2 in my project, that is right. And as far as I understand, I cannot save an image from the camera itself. The way I did it is by capturing the image and then saving it with the help of ign-common.

I think it may be better to implement the function or override it for Ogre2Camera. Otherwise, a lot of users will use the function without understanding why it does not do anything (which happened to me).

agayev169 avatar Jun 08 '20 21:06 agayev169

Understood. I don't think we'll have time to work on this anytime in the future, but pull requests are welcome :wink:

chapulina avatar Jun 08 '20 21:06 chapulina