gz-cmake
gz-cmake copied to clipboard
gazebosim
Clarify desired location of copyright notices in cmake modules
Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
In my haste to merge pull request #1, there were some comments that didn't get fully resolved:
@mxgrey can you take one more look at these comment threads?
Original comment by Michael Grey (Bitbucket: mxgrey, GitHub: mxgrey).
Regarding the testing, it doesn't look like we're making use of CTest, so I'd rather not pull that in entirely, but it does make sense for us to use an option called BUILD_TESTING if that's a conventional name for a testing toggle variable.
Regarding the copyright notices, I don't really have an opinion on the matter, so I'd very much welcome feedback on what style we should prefer for cmake modules.
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
We are now using BUILD_TESTING as of pull request #6 and pull request #7.
So the only unresolved comment is the location of copyright notices for cmake modules. I'll edit the issue title to match.
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
- changed priority from "major" to "minor"
- changed title from "Add missed comments from pull request #1" to "Clarify desired location of copyright notices in cmake modules"
I think this is the correct link to the comment related to copyright location:
- https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-cmake/pull-requests/1/page/1#comment-46077191
I'm guessing the question is about how some files (like FindAVCODEC.cmake) have the license starting at the first line of the file, whereas other cmake files (like GzConfigureBuild.cmake)have a short preamble before the license.
I don't really care; I would be fine closing it. Feel free to do so if you agree
There are also a few files that don't have the license in the file at all. Is it necessary to have the license in each file if we have a LICENSE file at the root?