gz-cmake icon indicating copy to clipboard operation
gz-cmake copied to clipboard

MSVC runtime libraries are installed on Windows

Open cottsay opened this issue 4 years ago • 2 comments
trafficstars

Environment

  • OS Version: Windows 10
  • Source ~~or binary build~~? 44a699c
    ...
    -- Install configuration: "Release"
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140_1.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140_2.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140_atomic_wait.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/msvcp140_codecvt_ids.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/vcruntime140_1.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/vcruntime140.dll
    -- Installing: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin/concrt140.dll
    -- Up-to-date: C:/ci/ws/build/ignition_cmake2_vendor/ignition_cmake2_vendor_install/bin
    ...

Description

  • Expected behavior: No binary files are installed by this package
  • Actual behavior: MSVC runtime libraries are installed by this package

Steps to reproduce

  1. Build on Windows
  2. Install on Windows
  3. Observe the list of operations performed during install

cottsay avatar Sep 18 '21 00:09 cottsay

To avoid that, in conda-forge recipes we pass the CMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP option, see https://github.com/conda-forge/libignition-math4-feedstock/blob/31df1d0d6d4f6d372061a8e4ce45d5923468a5f4/recipe/bld.bat#L8 .

traversaro avatar Sep 20 '21 12:09 traversaro

Note that this is due to https://github.com/ignitionrobotics/ign-cmake/blob/c34873d6c6bb301d5a865497483f4399d84c28b8/cmake/IgnPackaging.cmake#L58 .

traversaro avatar Sep 20 '21 12:09 traversaro