Gabriel Arcangel Zayas

Register Capypara actions for alert and confirm methods

3

Closes #54. This will add `accept_alert` to a test like this: ```ruby require "application_system_test_case" class BasicsTest < ApplicationSystemTestCase test "getting started" do visit root_path click_on 'Link to Alert' accept_alert end...

Besides the changes I added here, the following two methods stood out to me: 1. `keyDownFunction` 2. `keyUpFunction` There's some duplicate code here so I'd be glad to refactor some...

Potentially create abstraction for testingOutput sender arguments

1

https://github.com/bullet-train-co/magic_test/blob/b086d2f9bdfcbbe1b3d5283fa10fd5877f73256b/app/views/magic_test/_javascript_helpers.html#L12-L14 I'm seeing these three values grouped together often like this: ```js testingOutput.push({action: action, target: target, options: options }); ``` Curious if we should make an abstraction of this object...

Add CircleCI with tests linked to starter repository

1

Closes #92.

If no JavaScript is recorded, `output` is simply an empty array, so the following else statement never gets the chance to run: ```ruby if output # ... else puts "`window.testingOutput`...

Very minor, but the text here was bothering me so I updated it.

I would like to use a linter like I stated in #95, but since the JS logic is within HTML partials, I wasn't able to lint things with ESLint. In...

Use a JavaScript linter

2

Looking at the views, there is a lot of JavaScript there that isn't styled consistently. I'm seeing we don't have a package manager right now, but it might be good...

`MAGIC_TEST=1` doesn't work in `application.yml`

1

When adding an environment variable config file with [figaro](https://github.com/laserlemon/figaro), placing `MAGIC_TEST=1` in the file and running `rails test test/system/basics_test.rb` doesn't work for me. Error Log ``` > rails test test/system/basics_test.rb...

Documentation fixes

1

Minor documentation fixes. Also, Florian Plank's Twitter account doesn't exist anymore, so I pointed the link to the GitHub account instead.