Gael Pasgrimaud

Results 90 comments of Gael Pasgrimaud

Yeah you cant install from github's tarball. this is because external resources are fetched with bower: https://github.com/gawel/impress/blob/master/bower.json Don't know if I can disable tarballs. Btw I wont fix this. I'd...

Hi, aiohttp wasn't created when the plugin was written. It's probably a better option than `run_in_executor`. But your PR is fine.

Hi, there is a few tests showing that it should works https://github.com/gawel/irc3/blob/master/tests/test_logger.py

I'm too slow for pastebin... (sorry) Your pastes has been removed.

Hi, You can set `max_length` in the config file. Default value is 512: https://github.com/gawel/irc3/blob/master/irc3/base.py#L75

It's possible. But the rfc say 512 is fine: https://github.com/gawel/irc3/blob/2d7d65ca753fdd13b686d0ba5d4c180131ada6f6/irc3/rfc2812.txt#L300 You may be able to track this for your server by checking `bot.config['server_config']` See https://github.com/gawel/irc3/blob/2d7d65ca753fdd13b686d0ba5d4c180131ada6f6/irc3/plugins/core.py#L109

As I remember you can track what the bot receive/send by using `irc3 -vdr config.ini`

Thanks for digging into that. I don't like the idea of encoding/decoding the whole messages to... re-encode them before sending to the server. encoding/decoding are very CPU expensive AFAIK.

I'll be ok with that if there is no need to re-decode the data. I'm pretty sure a few `if isinstance(data, bytes)` will be faster than decoding/encoding the whole messages...

For now I've added a prefix argument to split_message (inspired by your snippet). This should reduce your amount of errors. Maybe it's enough to "fix" the problem if you set...