Dates.Recurring icon indicating copy to clipboard operation
Dates.Recurring copied to clipboard

Published 20 hours ago • verified publisher icon gavynriebau

Added Ending After Method to Builders

Open bbuchanan15 opened this issue 4 years ago • 1 comments

Hey @gavynriebau, I needed a way to specify after a certain number of iterations in a recurrence to return a null date, showing that the recurrence is over. I added EndingAfter method to the builders that take in an int which specifies the number of times the user intends for the recurrence to happen.

I'm using your library to create schedules with parameters similar to Outlook or Google Calendar, where one of the options is to select is a "ends after" so many occurrences of the event. This seemed like something that might be useful to others, which is why I'm submitting this pull request. Let me know what you think.

Thanks.

bbuchanan15 avatar Jan 14 '21 13:01 bbuchanan15

It's not my library.

On Thu, 14 Jan 2021, 13:23 Brandon Buchanan, [email protected] wrote:

Hey @nikkilocke https://github.com/nikkilocke, I needed a way to specify after a certain number of iterations in a recurrence to return a null date, showing that the recurrence is over. I added EndingAfter method to the builders that take in an int which specifies the number of times the user intends for the recurrence to happen.

I'm using your library to create schedules with parameters similar to Outlook or Google Calendar, where one of the options is to select is a "ends after" so many occurrences of the event. This seemed like something that might be useful to others, which is why I'm submitting this pull request. Let me know what you think.

Thanks.

You can view, comment on, or merge this pull request online at:

https://github.com/gavynriebau/Dates.Recurring/pull/20 Commit Summary

  • added ending after method to builders

File Changes

Patch Links:

  • https://github.com/gavynriebau/Dates.Recurring/pull/20.patch
  • https://github.com/gavynriebau/Dates.Recurring/pull/20.diff

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gavynriebau/Dates.Recurring/pull/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFG76KFEPYXG223QG2XOLLSZ3V65ANCNFSM4WCNRGWQ .

nikkilocke avatar Jan 14 '21 17:01 nikkilocke