Gavish Poddar
Gavish Poddar
Hi @noviluni, @lopuhin, @kishan3 The new `search_dates` implementation is nearing its completion. Code reviews would be great to receive.
I need help with one test `StaticTzInfo 'UTC'` is expected. `UTC` is received from new `search_dates`
Hi after some changes the codes are very much compatible with the old `search_dates`. Some tests are modified as the working of the `search_dates` has been changed. Currently, this PR...
Please use this [link](https://github.com/scrapinghub/dateparser/pull/945/commits/5a1b1c53f46a88f9a5fb58a234f04fe37dffe4f2) to see changes to tests.
### Speed New Implementation (This PR) - 44.380413369 seconds Old Implementation - 44.226806061 seconds ### After removing dates New Implementation (This PR) - 42.456919767seconds Old Implementation - 40.198545251 seconds ###...
### New speed test New Implementation (This PR) - 44.228506362999994 seconds Old Implementation - 44.339635815 seconds ### New speed test with the Spanish language Note: Only one date object was...
Hi @lopuhin, @noviluni, @kishan3 Please suggest should I go ahead and replace the `search_dates`, some more tests are required or keeping both the implementation.
Replaced previous `search_dates` with the new implimentaion
Hey, this PR is updated with the #932
Hi, I have made the changes