SuperStop icon indicating copy to clipboard operation
SuperStop copied to clipboard

Request: button

Open rayman89 opened this issue 6 years ago • 6 comments

Could you add a button that does the addon functionality? I tend to forget I have the addon otherwise.

rayman89 avatar May 30 '18 14:05 rayman89

are you still working on the addon @gavinsharp

rayman89 avatar Jul 10 '18 17:07 rayman89

@gavinsharp isn't, but I am, from time to time. (Sorry, I got a notification about this issue, then completely forgot about it.) This seems like a good idea, though it requires me spending some free time to code it, and also to design a button. Also, I wonder whether WebExtensions supports having a button being invisible by default.

simonlindholm avatar Jul 10 '18 17:07 simonlindholm

(oh, it does! "default_area": "menupanel")

simonlindholm avatar Jul 10 '18 17:07 simonlindholm

Thank you for your response. The button icon can be anything for example https://www.shutterstock.com/image-vector/gif-animation-button-icon-452957236 with red cross or prohibit sign over it https://www.shutterstock.com/image-vector/prohibition-sign-template-326440301?src=0Bu0j6W03qlt4H3j_m2QRg-1-6 . Also there is no need to make it invisible IMO. The users that do not want the button can remove it right clicking on the toolbar and selecting customize.

EDIT: great even better then

rayman89 avatar Jul 10 '18 17:07 rayman89

Yep, it's definitely one of the simplest things to find an icon for, but you'd still have to muck about with licenses and sizes and make it look good in the Firefox UI.

If you want to you could definitely try adding the button yourself, it should be pretty simple. Just add a browser_action to manifest.json, and a browserAction listener that does sendMessageToActiveTab({type: "do-super-stop"});. According to this article it should be simple to test it via about:debugging.

simonlindholm avatar Jul 10 '18 18:07 simonlindholm

I would love to do that but I'm not a dev sadly. I'll be looking forward for the update when you are able to do it. Thank you.

rayman89 avatar Jul 10 '18 19:07 rayman89