mod_auth_tkt icon indicating copy to clipboard operation
mod_auth_tkt copied to clipboard

Copy Host header before modifying in get_domain()

Open mocmocamoc opened this issue 9 years ago • 1 comments

At the moment get_domain() will strip the port number from the original Host header, meaning that subsequent functions that use the header will find it missing the port number. For example, redirect() calls get_domain() before itself retrieving the Host header, so the port number will always be gone before redirect() can get it.

mocmocamoc avatar Aug 25 '15 12:08 mocmocamoc

This is a valid issue, but a better fix is:

domain = apr_pstrdup(r->pool, domain);

ronisaacson avatar Oct 04 '18 21:10 ronisaacson