platinum-md icon indicating copy to clipboard operation
platinum-md copied to clipboard

Integrate netmd-js

Open gavinbenda opened this issue 4 years ago • 2 comments

https://github.com/cybercase/netmd-js is a JS port of netmdcli - this solves quite a few issues regarding having to bundle pre-compiled executives, and is a direct plug-in replacement that will work seamlessly with the platinum-md codebase.

This had a dependency on https://github.com/thegecko/webusb supporting the "Select USB" dialog in Electron. Issue has been opened here: https://github.com/thegecko/webusb/issues/66 and mentioned here also: https://github.com/electron/electron/issues/14545

gavinbenda avatar Apr 22 '20 15:04 gavinbenda

@cybercase I hope you are reading about the Electron issue. What I'm worried about is that Platinum-MD will rely too much on Chromium as it takes on parts from WebMD. Then this will no longer work on older pc systems. Platinum-MD is using Electron which is dangerous by itself already. I opted for the QHiMDTransfer route since QT is working fine on my older pc, however there are no newer windows builds yet because of a missing Travis configuration. That's why I ask you guys to develop Platinum-MD / WebMD further to have an alternative for my phone.

https://github.com/linux-minidisc/linux-minidisc/commit/43a01190f819e44c5709017b889be9bf8766b989

Invictaz avatar Apr 22 '20 18:04 Invictaz

Also Gavin it might rely on WebUSB which is a security risk according to Mozilla. Platinum-MD for now is safe as it runs isolated from the internet browser

https://github.com/cybercase/webminidisc/issues/5

Invictaz avatar Apr 22 '20 21:04 Invictaz