Gavin Ballard

Results 66 comments of Gavin Ballard

Hey @dhruveonmars, currently looks like some CSS/JS issues on that development site.

@dhruveonmars can you please try updating to v1.0.2 of Cart.js (just released) to see if the new cache-busting code addresses this problem?

Hey @bakura10 I'm going to take a look at this soonish. Would you be able to share the manual code you wrote for this?

Thanks @bakura10 - this is really useful. Will probably ping you for feedback on the WIP branch once I get around to working on this. :)

@devmpet Not yet! I have approximately zero time to contribute to CartJS at the moment, although I'm always happy to review pull requests and bump new versions.

@devmpet No worries, didn't want that to come off as defensive - just a fact of life at the moment unfortunately! Would love to look at a PR if what...

@adamrasheed Not sure if this site is currently using Cart.js - couldn't find it in the console. Point me to the page / LMK if no longer valid?

Because it's possible that multiple changes could occur in a single "request" (because `cart.requestStarted` triggers at the start of queue processing, and `cart.requestComplete` triggers at the end), I wonder if...

The latter part of my suggestion has just been pushed in v0.2.4! Leaving this issue open as the more advanced changes are probably helpful too.

@bakura10, keen to hear your use cases so that I can make sure this feature is the most useful it can be!