gautaz

Results 56 comments of gautaz

The same error occurs for the [p-queue](https://github.com/sindresorhus/p-queue) package which `package.json` only shows an `exports` field and no `main` field. I agree that this is rather odd considering what is currently...

Hello @icebob, thank you for shedding some light on the subject ! > The protobuf and thrift generates codes which contains the second require. We can't wrap it with a...

@devinrhode2 Thanks for taking care of the stale bot :-). I took the opportunity to take into account the latest commits on the main branch.

@devinrhode2 > Is there any good way I can view the diff from before+after your force push? AFAIK there is no way to do that because a force push basically...

Hello @typicode, I don't mean to be rude but would you please mind having a look at this PR and give me some feedback? If the current implementation does not...

Hello @devinrhode2 , thanks for the review :smile:. Yes, the default github diff does not ignore whitespaces, you can change that easily : https://stackoverflow.com/questions/37007300/how-to-ignore-whitespace-in-github-when-comparing Applying this renders the following (which...

@devinrhode2 You're right, it's best if the PR does not play with the dependencies versions, it is unrelated to the PR original intent. I will remove this from the PR....

Done. The `package-lock.json` file is still currently modified by `npm i` for just on line: ![image](https://user-images.githubusercontent.com/11046232/172405150-df5e0280-9f01-4481-972e-4aab0745fd10.png) Which is because its node requirement is not in sync with the one detailed...

> I have 4 "TODO" comments, 2 "optional", 2 seem more meaningful Thanks a lot @devinrhode2 :smile:, I'll look into them ASAP.

Hello @devinrhode2, A little recap of the latest modifications: - the missing backquote in documentation has been fixed - I followed your recommendation to use `Partial` for the `CustomOptions` declaration...