David Fridrich comments

Results 99 comments of


                                            David Fridrich

Add namespace validation to catch invalid names before build/deploy

/lgtm /approve

Add domain validation to catch invalid names before build/deploy

/ok-to-test

Add domain validation to catch invalid names before build/deploy

/retest

Add domain validation to catch invalid names before build/deploy

I think it would be better to keep the `utils` as small as possible, since this PR addresses domains, we need domains only in deploy so it would be better...

Add early cluster validation to prevent wasted build time in func deploy

/ok-to-test

Add early cluster validation to prevent wasted build time in func deploy

Im not much of a fan of this implementation... its still "test aware" as Matej said - with those literal strings and constants. Also there has to be some better...

Add early cluster validation to prevent wasted build time in func deploy

/override ?

Add early cluster validation to prevent wasted build time in func deploy

/override "On Cluster RT Test (ubuntu-latest, pack)" "E2E Test (ubuntu-latest, springboot)"

Add early cluster validation to prevent wasted build time in func deploy

These fails are unrelated. Its an issue with our custom pack builder currently

Add early cluster validation to prevent wasted build time in func deploy

/lgtm /approve