Lots of new failures since release 1.0.14

[rfay]

Suddenly (apparently with release of 1.0.14) I get piles and piles of link-check failures.

See https://github.com/drud/ddev/runs/5561841543?check_suite_focus=true for example, but it's quite consistent.

• Several external links show as 503
• Several relative links to markdown files show 400 (but there are plenty that don't)

All the checks are in open-source stuff, you can easily see what's going on,

• https://github.com/drud/ddev/tree/master/docs
• https://github.com/drud/ddev/blob/master/markdown-link-check.json

[rfay]

Rolling back to 1.0.13 in https://github.com/drud/ddev/pull/3706 does in fact fix all the markdown link errors. There are still two weird external 503s, but those can simply be ignored I guess. The two 503s are to things on php.net; curls to those URLs come out clean, but apparently curls from inside this action result in 503s.

[gaurav-nelson]

@rfay Thank you for reporting this. I'll check this one again to see what is happening. Otherwise revert back v1 to the old build.

[gaurav-nelson]

@rfay as a temporary fix, I've moved v1 back to 1.0.13. I still have to check why new mlc version is causing so many broken links.

[mockersf]

with the 1.0.14, links to anchors in a markdown files are failing the check

[jakemac53]

We are also getting failures for links to anchors in the current file, https://github.com/dart-lang/build/runs/5681705762#step:4:336

[gaurav-nelson]

I've marked v1.0.14 as a per-release version. Latest version on markdown-link-check includes checks for anchor links and that is causing lots of failed links.

[Adafede]

I am also experiencing lot of 503 on links that should not...

https://doi.org/10.1073/pnas.1509788112 https://doi.org/10.1111/2041-210X.12593

for example

[pacroy]

Same issue on relative link even on v1 (48954f3f5ef8c8a396061da12f2bbf5b686c05e5)

  ERROR: 1 dead links found!
  [✖] #inputs → Status: 404

[gaurav-nelson]

I tried debugging it and testing it locally but couldn't yet put my head around it. I couldn't even get it to work locally with markdown-link-check version 3.8.7 which is what this action was using in 1.0.13. I see it is checking anchor links by default. You are welcome to debug this issue. I think something changed in one of the dependencies of markdown-link-check module which is causing the issues. I'm not sure yet.

[pacroy]

Same issue on relative link even on v1 (48954f3)

  ERROR: 1 dead links found!
  [✖] #inputs → Status: 404

Thanks. This issue seems to be fixed already. 😄

[AleksanderBrzozowski]

We experienced the same problem when running check using [email protected]. Switching to version [email protected] works OK.

@gaurav-nelson When do you plan to release new version of the action which would contain downgrade to 3.8.7? ;)

[gaurav-nelson]

@AleksanderBrzozowski v1 is using 3.8.7 which was my last commit https://github.com/gaurav-nelson/github-action-markdown-link-check/commit/5c5dfc0ac2e225883c0e5f03a85311ec2830d368

Comparison between v1 and v1.0.13 https://github.com/gaurav-nelson/github-action-markdown-link-check/compare/1.0.13...v1

I'm not sure why but when I test even with 1.0.13 I still get failed anchor links.

[AleksanderBrzozowski]

Hm, is it possible to find which version of the markdown-link-check was used within action? I looked at logs and I couldn't find information about version :/

[gaurav-nelson]

@AleksanderBrzozowski yes its not in the logs. The version flag was implemented after mlc 3.8.7.

Can you try installing locally and check npm i -g [email protected] and then run the command to check a markdown file. I get failed anchor links. Which shouldn't be happening, but I guess some other mlc dependency is causing the issue.

[AleksanderBrzozowski]

ok, I use the action to check links in docs from this project.

When I run:

find docs/docs -name '*.md' -exec npx [email protected] -v -c .github/workflows/markdown-links-config.json {} \;

Everything works ok, no errors reported.

However, with version 3.9.1 it fails:

find docs/docs -name '*.md' -exec npx [email protected] -v -c .github/workflows/markdown-links-config.json {} \;

# example errors from logs:
FILE: docs/docs/configuration/kafka-and-zookeeper.md
  [✖] #multiple-kafka-and-zookeeper-clusters → Status: 404
  [✖] #single-kafka-cluster → Status: 404

[AleksanderBrzozowski]

@gaurav-nelson Can you check above? Are you sure that new version of the action has been successfully uploaded?

[gaurav-nelson]

@AleksanderBrzozowski I still can't make 1.0.13 work. For me it is failing on anchors PS: https://github.com/gaurav-nelson/test-mlc-action/runs/6185868294?check_suite_focus=true

[AleksanderBrzozowski]

Hm, it looks like that our workflow has picked up recent version, and everything started to work again ;) Is there any possibility to check which version of the action was used in a job? Here are logs from recent job run, the job is scheduled to execute every week.

[gaurav-nelson]

¯\_(ツ)_/¯ I'm not sure what's going on. I'll update the script to list out all the node modules in use and their version.

[gaurav-nelson]

@AleksanderBrzozowski PS: #137 Let me know if that is enough and I'll add it to v1.0.13 and v1

[AleksanderBrzozowski]

PR approved. I saw the logs of one of the checks and it looks nice :)

[danyalaytekin]

UPDATE: Probably a misunderstanding about the action's permissions. Nothing to see here...

---

As far as I can tell, from testing the last couple of days:

• v1 fixes the Git issue, but not the 404 issue
• 1.0.13 may well fix the 404 issue, but I can't get around the Git issue

Any advice?

[gaurav-nelson]

@danyalaytekin @rfay @AleksanderBrzozowski I've updated 1.0.14 which includes latest mlc version and fixes some other issues. Can you check and confirm if that solves your problem?

[rfay]

@gaurav-nelson if I understand you correctly you "updated" 1.0.14 rather than releasing a new version. Please don't ever do that. An existing release should never be changed. Rather, release a new version, like a v1.0.15.

I'll do a PR on DDEV to check v1.0.14

[rfay]

I got a successful run, but I note I had added

  "httpHeaders": [
    {
      "urls": ["https://github.com/", "https://guides.github.com/", "https://help.github.com/", "https://docs.github.com/"],
      "headers": {
        "Accept-Encoding": "zstd, br, gzip, deflate"
      }
    }
  ],

to markdown-link-check.json... wasn't that part of this issue?

[AleksanderBrzozowski]

I got a successful run too :) In my case, there wasn't any change in a configuration file.

[gaurav-nelson]

Thank you @rfay @AleksanderBrzozowski for testing it out.

@rfay That is a custom option people need to specify in the configuration file. I've added it to README at https://github.com/gaurav-nelson/github-action-markdown-link-check#github-links-failure-fix

Thank you for recommending about releasing a new version. I'll make sure I don't overwrite versions.