tach icon indicating copy to clipboard operation
tach copied to clipboard

Support file globbing in exclude_paths

Open emdoyle opened this issue 1 year ago β€’ 8 comments
trafficstars

As mentioned in #101, it's confusing that exclude_paths uses regex instead of file globbing.

Conceptually, this behavior should match that of other linters like ruff. Using that example, it makes sense to support globset: https://docs.astral.sh/ruff/settings/#exclude https://docs.rs/globset/latest/globset/#syntax

This will require updating the docs to explain the new behavior.

emdoyle avatar Jun 21 '24 01:06 emdoyle

hey @emdoyle I would love to work on this issue. since, its good first issue πŸ‘

shreyash2002 avatar Jun 24 '24 08:06 shreyash2002

hey @emdoyle I would love to work on this issue. since, its good first issue πŸ‘

Sounds great! Feel free to put up a PR any time, and ask me if anything is unclear.

emdoyle avatar Jun 24 '24 21:06 emdoyle

@shreyash2002 is this still something you'd like to work on? Otherwise I'll unassign so that someone else can pick it up.

emdoyle avatar Jul 09 '24 21:07 emdoyle

Hi @emdoyle,

Is this issue still open? If so, could you please assign it to me? I would love to work on it over the weekend!

legendkartik45 avatar Jul 28 '24 12:07 legendkartik45

@legendkartik45 That would be great, thanks! I might also recommend basing your branch on #208 to avoid significant merge conflicts when your changes are ready.

emdoyle avatar Jul 29 '24 05:07 emdoyle

Hey @legendkartik45! Are you still working on this issue?

caelean avatar Aug 01 '24 17:08 caelean

@legendkartik45 going to open this one back up for other folks

caelean avatar Aug 05 '24 19:08 caelean

I tried fixing this issue here - https://github.com/gauge-sh/tach/pull/234

architgarg avatar Aug 06 '24 16:08 architgarg

Resolved in #259

sparshg avatar Aug 24 '24 17:08 sparshg