bridge icon indicating copy to clipboard operation
bridge copied to clipboard

Loosen dependency versions, add resiliency

Open WoosterInitiative opened this issue 1 year ago • 3 comments

All dependencies were pinned to specific versions which would fight with whatever project it was implemented in. Loosened them while trying to keep them reasonable.

Added a timeout for waiting for postgres to be ready.

WoosterInitiative avatar Jun 19 '24 20:06 WoosterInitiative

OK, changes have been made.

I haven't been able to run tach on it, however. Seems to be an issue with pydantic? I don't have time right now to dig into that, but I also couldn't run tests on the tach package. I'm in Windows, fwiw.

WoosterInitiative avatar Jun 24 '24 16:06 WoosterInitiative

This would also close #29

WoosterInitiative avatar Jun 24 '24 17:06 WoosterInitiative

OK, changes have been made.

I haven't been able to run tach on it, however. Seems to be an issue with pydantic? I don't have time right now to dig into that, but I also couldn't run tests on the tach package. I'm in Windows, fwiw.

Apologies for the delay on this, but thanks! I think the service/docker.py file also needs the future statement but should be good to go otherwise.

The issue with Tach sounds like a known issue with backward compatibility in Tach. I'd check what version you are running and make sure it matches 0.1.2 (in dev-dependencies). If it does match, then I think ignore any failures for now since it will be a separate task to upgrade to the latest version of Tach anyway.

emdoyle avatar Jul 04 '24 06:07 emdoyle