gatsby icon indicating copy to clipboard operation
gatsby copied to clipboard

Gatsby's documentation about visual testing with storybook is out of date / not working.

Open darylthornhill opened this issue 1 year ago β€’ 24 comments

Preliminary Checks

  • [X] This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/gatsbyjs/gatsby/issues
  • [X] This issue is not a question, feature request, RFC, or anything other than a bug report. Please post those things in GitHub Discussions: https://github.com/gatsbyjs/gatsby/discussions

Summary

Storybook has had an update and the documentation linked to configuring storybook no longer works!

Also Gatsby's Link component doesnt play nice with storybook any longer. This is how i came across the issue with this part of the documentation.

Im not sure exactly on how to resolve these issues, but thought it would be worth reporting incase other people have any issues setting it up in the mean time!

Steps to Resolve this Issue

  1. download https://github.com/darylthornhill/test-gatsby-storybook-error npm run storybook to start storybook and see the errors with Gatsby Link.
  2. After trying that, copy and paste the example code pieces for the main.js and the preview.js into the respective files and run npm run storybook and see further errors.

darylthornhill avatar Apr 12 '23 20:04 darylthornhill

Hi, thanks for the issue!

I don't personally use Storybook and we probably also won't spend any time writing glue code for this. I assume you refer to the 7.0 release? https://storybook.js.org/releases/7.0

If I read it correctly, they introduced a new API: https://storybook.js.org/blog/framework-api/ But I couldn't find anything for Gatsby.

It seems like https://storybook.js.org/docs/react/contribute/framework needs to be followed for Gatsby now. But again, we don't have time to do this, so it's up for the community to contribute this.

However, I've seen https://github.com/storybookjs/storybook/issues/22065, so happy to help updating our docs.

LekoArts avatar Apr 13 '23 06:04 LekoArts

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar May 03 '23 12:05 github-actions[bot]

Still an issue

rasmusbe avatar May 03 '23 12:05 rasmusbe

Hey! Is this issue still open?

Vishrut19 avatar May 18 '23 04:05 Vishrut19

Looks like storybook's own Gatsby example is broken on their v7 version, so they need to provide guidance on what should change. There is already an open issue on the Storybook repo. Since the issue was introduced by them, it will be tracked there. I guess this can remain open to update docs once the underlying functionality is fixed.

https://github.com/storybookjs/storybook/issues/21958

graysonhicks avatar May 23 '23 18:05 graysonhicks

will be better if a Video tutorial is made.

hameemkay avatar May 29 '23 07:05 hameemkay

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Jun 18 '23 12:06 github-actions[bot]

Still an issue

rasmusbe avatar Jun 19 '23 08:06 rasmusbe

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Jul 10 '23 00:07 github-actions[bot]

can someone assign me this issue? would love to work on it!

ranjanmangla1 avatar Jul 10 '23 18:07 ranjanmangla1

I have already asked for it. Let's see

Vishrut19 avatar Jul 10 '23 19:07 Vishrut19

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Jul 31 '23 12:07 github-actions[bot]

Hi I can work on the issue if its still open

quantumflo avatar Aug 24 '23 17:08 quantumflo

Lets work on this

VineeTagarwaL-code avatar Sep 09 '23 18:09 VineeTagarwaL-code

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Sep 30 '23 00:09 github-actions[bot]

Still an issue

salonisahu avatar Oct 04 '23 21:10 salonisahu

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Oct 25 '23 12:10 github-actions[bot]

Issue?

apneduniya avatar Nov 06 '23 13:11 apneduniya

Is this still an issue?

TheShiveshNetwork avatar Nov 23 '23 15:11 TheShiveshNetwork

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Dec 14 '23 00:12 github-actions[bot]

Still an issue for me: I'm not able to update from the storybook 6.5 version, which consequentially (for particular conditions) blocks me from updating typescript from the 4.7 version

bwlt avatar Dec 14 '23 10:12 bwlt

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Jan 04 '24 00:01 github-actions[bot]

still an issue

jdahdah avatar Feb 06 '24 14:02 jdahdah

can I work on this issue ?

yacxn avatar Feb 07 '24 00:02 yacxn

Hiya!

This issue has gone quiet. Spooky quiet. πŸ‘»

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Feb 27 '24 12:02 github-actions[bot]

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else. As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! πŸ’ͺπŸ’œ

github-actions[bot] avatar Apr 07 '24 12:04 github-actions[bot]