gatsby-plugin-s3 icon indicating copy to clipboard operation
gatsby-plugin-s3 copied to clipboard

Published 20 hours ago • verified publisher icon gatsby-uc

Seems `gatsby-plugin-s3 deploy` always sets ErrorDocument to 404.html

Open peteryhwong opened this issue 2 years ago • 2 comments

Seems when we run gatsby-plugin-s3 deploy an putBucketWebsite is sent and hardcodes 404.html to be ErrorDocument even if the targeted s3 bucket is not configured to use 404.html as ErrorDocument.

https://github.com/jariz/gatsby-plugin-s3/blob/9365136039514771d03f965d4f240f55fc7722e7/gatsby-plugin-s3/src/bin.ts#L215

peteryhwong avatar Oct 19 '22 02:10 peteryhwong

I'll happily review a PR that makes this configurable. Is there a particular reason why you want your ErrorDocument to be called something else though? The easiest fix here is to call your error document 404.html.

YoshiWalsh avatar Oct 19 '22 05:10 YoshiWalsh

Thanks @JoshuaWalsh . See https://github.com/jariz/gatsby-plugin-s3/pull/369 a PR for making this configurable

peteryhwong avatar Oct 30 '22 12:10 peteryhwong