lap
lap copied to clipboard
Add numpy and cython to setup requirements
I added the numpy and cython to setup.py requirements. This enables pip installing this repo without having to manually install numpy and cython beforehand.
I'm still getting this error:

I'm not sure if this change is 100% ready but it works for me and the test pass.
@gatagat what do you think about this one?
I don't think this is solving the issue. The install_requires setting is for runtime dependencies, not setup time dependencies. So adding cython/numpy to install_requires will not ensure that it is installed when setup.py runs and these packages are needed.
There are three possibilities:
- Avoid requiring those packages at setup time by pre-generating and distributing the cythonized pyx file.
- Avoid requiring the setup itself as per PEP517/518 + e.g. flit.
- Publish wheels for major systems making it even simpler for users (no compiler required).