webbybot icon indicating copy to clipboard operation
webbybot copied to clipboard

Published 20 hours ago • verified publisher icon gasolin

make ExpressRouter replaceable

Open gasolin opened this issue 8 years ago • 4 comments

to 4.x

gasolin avatar Mar 10 '16 05:03 gasolin

consider make it replaceable such as https://github.com/github/hubot/pull/1134/files

gasolin avatar Apr 05 '16 14:04 gasolin

would this mean that express itself wouldn't have to be a dependency? Over half of this project's dependencies come in via express. The full left and bottom part of this graph are express. Only the top right stuff is the rest of webbybot.

grafik

http://npm.anvaka.com/#/view/2d/webbybot

ccoenen avatar Dec 05 '16 10:12 ccoenen

no, it means we'd usenewer express version to avoid related security issue.Now webbybot already pick different express version(4) compare to hubot(3)

gasolin avatar Dec 06 '16 18:12 gasolin

Actually hubot only use a small portion of express, so theoretically we can totally replace it. But it should be carefully done when compatibility is in concern.

gasolin avatar Dec 12 '16 06:12 gasolin