Gabriel Scherer
Gabriel Scherer
I found out by chance (reading the make build logs) that there is a `utils/strongly_connected_components.ml` module. If no one is willing to review my lovely code, I could maybe try...
Is someone planning to submit a PR that does this?
@lthls I think that your PR is better than the present PR because it is simpler -- so let's close this one. If we want to improve closure computation (which...
Note: I think this is related to https://github.com/ocaml/RFCs/pull/26 .
I wonder if it is related to [#12889](https://github.com/ocaml/ocaml/pull/12889), the only recent change to Domain.DLS that I can think of. (I hope not!)
Is there more information that we can use to try to investigate this? "There is a segfault somewhere in Domain.DLS on 32bit" is not that much.
No snark intended, I genuinely wonder how you work with these failures. For example I'm not sure if it is reasonably easy to extract a backtrace, and/or to observe the...
How easy/hard would it be for you to run the testsuite on an arbitrary patch, if I send you changes to the runtime that might be related to the crash?
Here is a proposed small patch for example: https://github.com/gasche/ocaml/commits/mysterious-dls-crash-1/ (Another obvious idea would be to revert #12889 and see whether you can still reproduce the crash. I don't see any...
Thanks! This change is really a blind move, so it is unlikely to work. I think the reasonable next step is to revert #12889. Let me know if you need...