Results 1654 comments of Gabriel Scherer

I published more detailed microbenchmark results in [dynarray-benchmarks/BENCH.md](https://gitlab.com/gasche/dynarray-benchmarks/-/blob/trunk/BENCH.md?ref_type=heads), in case someone wants to look at the gory details. My summary of the results would be as follows: - For stack-like...

@alainfrisch I am trying to avoid bad interactions between the cyclic dummy (for marshalling) and comparison by... hiding the cycle inside an object. It feels like fighting fire with fire,...

The dummy is shared between all dynarrays created by the program, so the empty-object creation happens only once at runtime. (Unmarshalling may create new dummies on the fly; so there...

@damiendoligez, @OlivierNicole : you both worked on #12889, I wonder if you may be interested in looking at this one as well -- it is more work. (I don't disagree...

I need to go over the other comments in @OlivierNicole's review, and rebase the PR on top of the current trunk. Thanks!

This is a good idea, but it does not belong to the current PR. You could open an issue (or a PR!) for this. I'm happy to implement it when...

I went over @OlivierNicole's comments and rebased the PR against trunk. I will merge if the CI agrees.

Thanks again to all reviewers and in particular @OlivierNicole, this was a tricky one. Things that would be worth doing as follow-up work: - implement `compare` and `equal` - introduce...

As a non-expert, I find it very tricky that `caml_minor_collection` does not do what one would expect, and I find the approach of #12882 (where it does provide the expected...

#12742 was reviewed by @gadmm who mentioned that the assertion could also be hit when using statmemprof (which changes the young limit). How does that factor into the current reasoning?