Gabriel Scherer
Gabriel Scherer
For `foo.bar.cmo` are we sure that the previous compiler would only look at `foo.cmi`, and not also `foo.bar.cmi`? If we wanted to support both positions as possible, would we end...
I propose to fix the bug first in a way that is acceptable -- I think that merging the PR as-is (with the typo fixed) is reasonable and good enough...
@Octachron I'm not fond of #12988 as a proposed fix to this issue. My understanding is that when there are several choices that are just as good (from the algorithm's...
My money is on #12389 and #12545.
Thanks for the report. From the discuss discussion, it sounds like @dra27 successfully diagnosed the problem as follows: `.cmi` digests are different depending on whether zstd compression is enabled or...
(cc @MisterDA : a juicy change in the marshaller could be of interest to you)
In principle the change looks fine, I think this only needs a review for reasonableness and non-regression inside the type checker.
If I understand correctly, @Octachron did a substantial change just now, and we need a second review round of @lthls (or someone else) before we can merge.
@Octachron tried to do something "good" for this check in #10386, but I don't remember why it went nowhere -- except maybe "it's complex and no one knowledgeable was around...