Gabriel Scherer

Gentle ping. @brandonzstride , would you be available to push this past the finish line? If not, please feel free to say so, we can probably rebase and tweak the...

Out of curiosity. How do we test the issue and the proposed fix? What is the current behavior and what would be the expected behavior?

Wee could implement a different semantics where a module alias (here `F`) "inherits" the attributes of the aliased module (here `Foo`). But it is not clear to me that it...

I realize that I am myself confused by floating alerts. In the toplevel (5.1.0), compare: ```ocaml # module M = struct let x = 1 end [@@alert deprecated];; module M...

Possibly relevant: https://github.com/ocaml/RFCs/pull/26 .

Maybe there is a reasonable string-search implementation in OCaml somewhere out there (does not need to be the most elaborate algorithm ever), that could be used to propose a string...

My current thinking: - I agree with @dbuenzli that the `string`-needle implementation is more general and convenient, and that we should try to offer this. - If there was a...

If I understand correctly, we must be careful about what happens when trying `#install_printer` on a value whose type contains weak inference variables. I don't understand what it is that...

My impression is that "different identifiers will be printed differently" is part of the core contract/specification of name printing, and breaking it is a no-no. On the other hand, the...

I'm fine with the proposed design, but haven't done a review yet. I wonder if we should ask for `ocaml.5.2+effects` rather than just `5.2+effects` (or maybe support both), to leave...