Gabriel Scherer
Gabriel Scherer
I don't understand anymore why `Dummy.Array.blit` does not check for dummies in the source array. This does not seem correct? (Memory-safety is lost if two different dummies end up in...
(My current review state is that I'm waiting to see if @bclement-ocp wants to fix `Dummy.Array.blit` as part of this PR.)
Indeed, we are blessed with a new MSVC warning, see my investigation at https://github.com/ocaml/ocaml/pull/14059#issuecomment-2985738799 and a PR in progress at https://github.com/ocaml/ocaml/pull/14097 .
(My understanding again is that we are waiting for @bclement-ocp to tweak the PR slightly, which is fine with me.)
(gentle ping: I would be happy to be done with this PR, which improves the codebase)
I'm not sure what you want to do with the git history. My gut feeling is that it is not good enough now, so you should either clean it up...
There is now a failure in the following tests on the "normal" CI configuration: ``` tests/native-debugger/linux-gdb-amd64.ml tests/native-debugger/linux-lldb-amd64.ml ``` The observed diff in the CI result is as follows: ```diff @@...
Looking at the commits one-by-one, in many cases I feel a bit lost as I don't know what the purpose of the commit is. (Bonus point for the commit message...
If the PR is intended to be reviewed commit-by-commit, I think that it would be nice if the commits would come with a commit message that explains the change, maybe...
In general to print an error message we need to keep more metadata at the place where the error is detected and raised, rather than changing only the place where...