Gabriel Scherer
Gabriel Scherer
`is_principal` is available in trunk, but it is in Typecore. You can move it to Ctype as in the JS fork, but then you should remove the one in Typecore.
We now have a consensus among language maintainers to merge this feature, and the implementation has been reviewed for correctness. Great! But before I click "merge", I would like to...
(Also check-typo: no Changes, and line too long at `./typing/typecore.ml:3903.81`)
That seems very reasonable to me. But then I am not sure, as a user, how I would reason about the situation where a given constructor and its re-export use...
We don't have a good protocol for RFCs, the value is in the discussions I think. Merging would make sense, as it keeps a track record of RFCs we have...
Great! Feel free to ask if there is anything you need. I think that the starting point would be to make the change in `parsing/parsetree.{ml,mli}`, and fix all the places...
@damiendoligez would you be willing to have a look?
@damiendoligez gentle ping. (I'm happy to go bother other maintainers, maybe @OlivierNicole for example, if Damien is not available.)
@Octachron kindly reminded me in #14081 that this PR would be better off if it was finished. I'll try to integrate his review comments quickly (and then I suggest we...
I took current review comments into account, thanks @Octachron and @jmid!